drjones/th-analyzer
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

HTML reporter doesn't escape <>& in finding output #3

New Issue
Open
opened 2026-06-19 06:22:27 -07:00 by drjones · 0 comments
drjones commented 2026-06-19 06:22:27 -07:00
Owner
Copy Link

In engine/reporter.sh, finding evidence and exploit content is inserted directly into HTML without entity escaping. A finding containing <script>alert(1)</script> would execute in the HTML report.

Impact: Only affects the report viewer (internal). Not exploitable in the field since the report is local, but still bad practice.

Fix: Add a html_escape() function that replaces <, >, &, ", ' before inserting into the HTML template.

In `engine/reporter.sh`, finding evidence and exploit content is inserted directly into HTML without entity escaping. A finding containing `<script>alert(1)</script>` would execute in the HTML report. **Impact:** Only affects the report viewer (internal). Not exploitable in the field since the report is local, but still bad practice. **Fix:** Add a `html_escape()` function that replaces `<`, `>`, `&`, `"`, `'` before inserting into the HTML template.
drjones added the bug label 2026-06-19 06:22:27 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Confirmed bug
 enhancement
Enhancement or feature request
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
drjones
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: drjones/th-analyzer#3
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?