From f5e9b765fe0028576954d8d807e286abba24e2fe Mon Sep 17 00:00:00 2001 From: AetherForge Date: Sun, 7 Jun 2026 06:49:10 -0700 Subject: [PATCH] Fix erasure Params normalize test to match defaulting behavior. Non-positive shard counts normalize to 4+2 defaults rather than erroring; align TestParamsNormalizeDefaultsAndLimits with codec.Normalize semantics. --- server/internal/erasure/codec_test.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/server/internal/erasure/codec_test.go b/server/internal/erasure/codec_test.go index 16566ed..77fbc6e 100644 --- a/server/internal/erasure/codec_test.go +++ b/server/internal/erasure/codec_test.go @@ -78,12 +78,14 @@ func TestEncodeRejectsEmptyPayload(t *testing.T) { } } -func TestParamsNormalizeInvalid(t *testing.T) { - if _, err := (Params{DataShards: 0, ParityShards: 0}).Normalize(); err != nil { - t.Fatalf("zero values should normalize: %v", err) +func TestParamsNormalizeDefaultsAndLimits(t *testing.T) { + p, err := (Params{DataShards: 0, ParityShards: 0}).Normalize() + if err != nil || p.DataShards != DefaultDataShards || p.ParityShards != DefaultParityShards { + t.Fatalf("zero values should normalize to defaults: %+v err=%v", p, err) } - if _, err := (Params{DataShards: -1, ParityShards: 1}).Normalize(); err == nil { - t.Fatal("expected error for negative data shards") + p, err = (Params{DataShards: -1, ParityShards: 1}).Normalize() + if err != nil || p.DataShards != DefaultDataShards { + t.Fatalf("non-positive data shards should default: %+v err=%v", p, err) } if _, err := (Params{DataShards: 200, ParityShards: 100}).Normalize(); err == nil { t.Fatal("expected error for too many shards")